You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improving the UX of multi chain functionality by moving it from the side menu to a menu button and included a tag on the chain logo to indicate when the User is under a testnet environment.
Also, fixed a bug regarding authentication where the system was keeping the account connected when changing the network.
Test scenarios
Selected a testnet chain and checked if the testnet tag appears.
Changed from one chain to another and checked if the environment changes.
Checklist:
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have cleaned up the code in the areas my change touches
My changes generate no new warnings
I have checked my code and corrected any misspellings
The reason will be displayed to describe this comment to others. Learn more.
Could we include changing the url according to the selected chain?
This would enable link sharing to the precise transaction/account in the specific chain
for example, for telos we should add ?network=telos, based on the chain name we have on index.ts for each chain
Could we include changing the url according to the selected chain? This would enable link sharing to the precise transaction/account in the specific chain
for example, for telos we should add ?network=telos, based on the chain name we have on index.ts for each chain
I will do it in a different PR, opened #709 to keep track on this. This one will only change the side menu for the dropdown and update the ENV var name for it. Also, fixed some bugs on authentication regarding when change from one chain to another.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
karynemayer
force-pushed
the
new_multichain_selector
branch
from
Fixes #706
Fixes #705
Description
Improving the UX of multi chain functionality by moving it from the side menu to a menu button and included a tag on the chain logo to indicate when the User is under a testnet environment.
Also, fixed a bug regarding authentication where the system was keeping the account connected when changing the network.
Test scenarios
Checklist: